Poketch Memo Pad (ov24) Decompilation #551
Conversation
There was a problem hiding this comment.
firstly, thanks so much for the PR, it's not often that people contribute to diamond, not many people have an interest in it so it's always nice when someone makes a PR
I've labelled some things that need changing, of particular note is the pointer style, the * should be next to the variable name, on the right always, header declarations should also have the variable name there. It'd help massively if you documented as you went along (even best guess) it's fine if there's no info, but giving clues as to what a function does and parameter types helps hugely with further decompilation
thank you again
| } | ||
|
|
||
| BOOL ov24_0225489C(MemoPadAppHandler* appHandler, u32 arg1, u32 arg2, u32 arg3) { | ||
| static const u8 ov24_022550F8[] = { |
There was a problem hiding this comment.
genearlly these should be outside the function
There was a problem hiding this comment.
is this a general rule just for consistency? these aren't used anywhere else so my intuition would tell me that they're defined and used exclusively within the functions
There was a problem hiding this comment.
yeah a general rule for consistency
There was a problem hiding this comment.
ov24_022550F8 appears to denote the bounding boxes of the pencil and eraser buttons
| int a = (x >> 3) + (y >> 3) * 0x14; | ||
| int e = ((x + width - 1) >> 3) - (x >> 3) + 1; | ||
| int b = ((y + height - 1) >> 3) - (y >> 3) + 1; | ||
| while (b--) { |
There was a problem hiding this comment.
this feels like it should be a for loop, not a while loop
|
|
||
| void ov24_02255078(MemoPadDisplayHandler* displayHandler) { | ||
| // TODO: types | ||
| static const u32 ov24_0225514C[2][4] = { |
…consistency + some constants
|
Hi, just wanted to check up here and make sure this PR doesn't fall through the cracks if you're a bit busy, that's ok, just lmk when you've done it and I'll re-review |
|
sorry about the delay on this. should be fine now |
Some names are taken from pokeplatinum but otherwise are just whatever seemed reasonable. Not sure if there are any stylistic/naming standards that need to be taken into account.