Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup calcrom.pl (Manual OK bot) #22

Merged
merged 12 commits into from
Jun 25, 2023

Conversation

WhenGryphonsFly
Copy link
Collaborator

Description

Adds calcrom.pl to the .github directory in preparation of setting up OK bot. This version of calcrom is based on the ones found in pokefirered and pmd-red, with some modifications. Additional changes were made to other files as necessary.

Discord contact info

whengryphonsfly

Remaining issues:
* sub_??? (3 characters) need to be renamed to be considered undocumented
* TitleScreen??_Unknown need to be renamed to be considered partially undocumented
* Some .s files need to be moved to src (e.g., m4a_1.s)
* Include library code in calculation?
* Fix discarded input sections being considered
* Fix incbins
This commit allows calcrom to correctly calculate the number of undocumented and partially documented symbols
@WhenGryphonsFly WhenGryphonsFly merged commit c53395c into pret:master Jun 25, 2023
1 check passed
@WhenGryphonsFly WhenGryphonsFly deleted the working branch June 25, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant