Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new sqlcipher package #87

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Migrate to new sqlcipher package #87

merged 6 commits into from
Apr 22, 2024

Conversation

raphaelm
Copy link
Member

Google play marks the SQL cipher package as an outdated SDK and might block app releases in the future. This PR does the migration and unfortunately needs to vendor some requery code for that.

@robbi5
Copy link
Contributor

robbi5 commented Mar 25, 2024

This is also an upgrade from the sqlcipher major version 3 to 4.

https://discuss.zetetic.net/t/upgrading-to-sqlcipher-4/3283 says:

However, the introduction of new default algorithms, increased KDF iterations and a larger page size means that SQLCipher 4 will not open older databases by default.

We should do the PRAGMA cipher_migrate; call, or am I missing some place where it happens implicitly?

@robbi5
Copy link
Contributor

robbi5 commented Mar 27, 2024

Well, we don't do a automatic migration, but it looks like we kill and rebuild the database:

https://github.com/pretix/pretixscan-android/blob/master/pretixscan/app/src/main/java/eu/pretix/pretixscan/droid/PretixScan.kt#L54-L58

@raphaelm
Copy link
Member Author

ouch! how did i not notice that. no, that's not he goal xD

@raphaelm
Copy link
Member Author

raphaelm commented Apr 9, 2024

Oh wow, they could really have mentioned this or given better guidance :D Fixed!

@raphaelm raphaelm requested a review from robbi5 April 9, 2024 09:33
@raphaelm raphaelm merged commit 0b398ef into master Apr 22, 2024
1 check passed
@raphaelm raphaelm deleted the sqlchipher-next branch April 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants