Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TypeScript 5.5 #1063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}
},
"dependencies": {
"@typescript-eslint/parser": "^6.7.5",
"@typescript-eslint/parser": "^7.14.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be a breaking change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JounQin I guess it shouldn't be. CI is failing because of outdated node version

[lint] 36:5 error "@typescript-eslint/parser@^7.14.1" is not compatible with "node@>=16.10.0". Allowed is: "node@^18.18.0||>=20.0.0" node-dependencies/compat-engines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's a breaking change as it changes required node engine.

Maybe more breaking features should be considered, but I don't have enough time these days.

"common-tags": "^1.4.0",
"dlv": "^1.1.0",
"eslint": "^8.7.0",
Expand Down
Loading