Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label values can be like any strange text so this needs to be escaped.
php-prometheus/src/Serializer/PrometheusEncoder.php
Line 50 in 12bf879
since prometheus does not know any non numeric metric values, the metric value would not need the escape function, but I don't want to break any compatibility.
php-prometheus/src/Serializer/PrometheusEncoder.php
Line 30 in 12bf879
see:
prometheus/prometheus#2227
Best Regards
Nicolas