fix: Update styled-components #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9ad7e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prevwong
reviewed
Oct 21, 2024
.changeset/red-cameras-burn.md
Outdated
Comment on lines
1
to
4
| --- | ||
| '@craftjs/layers': minor | ||
| '@craftjs/core': patch | ||
| --- |
There was a problem hiding this comment.
- I don't think the core package needs an update since the changes here only affect the layers package?
- Can you change the
@craftjs/layersas apatchupdate instead? It's not ideal but the reason being we're still in major version 0 and we use the minor version to indicate a breaking change in Craft
There was a problem hiding this comment.
I have made these changes, just fighting with the test-suite. It's suddenly stopped recognising react-hooks when ran through @testing-library/react
There was a problem hiding this comment.
Done and pushed 😄
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #698
What?
styled-componentsfrom 4.X.X to 6.X.X.styled-componentsimports.Why?
Anyone working with a newer version of StyledComponents is unable to run CraftJS Layers in production due to the errors raised by breaking changes introduced in
"styled-components": ">= 6".We faced this while attempting to use CraftJS within Sanity CMS.
The latest API requires non-DOM related props to be passed as "transient props" via the specified API https://styled-components.com/docs/api#transient-props. Doing so removes the warning found in #698