fix: each env cache

prevwong · Jul 3, 2024 · ddf72b6 · ddf72b6
1 parent 43a7ad2
commit ddf72b6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/packages/core/src/each.ts b/packages/core/src/each.ts
@@ -30,7 +30,7 @@ export class EachDirectiveEvaluator {
     );
 
     this.eachExpr = template.each;
-    this.id = template.each.iterator.id;
+    this.id = template.each.id;
 
     this.items = new Map();
   }

diff --git a/packages/core/src/evaluator.ts b/packages/core/src/evaluator.ts
@@ -284,6 +284,8 @@ export class Evaluator {
 
       const prevEachExpr = untracked(() => template.each);
 
+      const env = ctx.env.inherit();
+
       const computation = computed(
         () => {
           /**
@@ -300,7 +302,7 @@ export class Evaluator {
           });
 
           if (template.if) {
-            const bool = this.computeExpr(template.if, ctx.env);
+            const bool = this.computeExpr(template.if, env);
 
             if (!bool) {
               return [];
@@ -331,12 +333,12 @@ export class Evaluator {
                   [] as string[]
                 );
 
-                ctx.env.set(ClassListBindingKey, {
+                env.set(ClassListBindingKey, {
                   readonly: true,
                   value: classListValue,
                 });
               } else {
-                ctx.env.set(ClassListBindingKey, {
+                env.set(ClassListBindingKey, {
                   readonly: true,
                   value: {},
                 });
@@ -354,19 +356,31 @@ export class Evaluator {
           let viewSet: t.View[] = [];
 
           if (template instanceof t.TagTemplate) {
-            viewSet = this.computeTagTemplate(template, ctx);
+            viewSet = this.computeTagTemplate(template, {
+              ...ctx,
+              env,
+            });
           }
 
           if (template instanceof t.ComponentTemplate) {
-            viewSet = this.computeComponentTemplate(template, ctx);
+            viewSet = this.computeComponentTemplate(template, {
+              ...ctx,
+              env,
+            });
           }
 
           if (template instanceof t.SlotTemplate) {
-            viewSet = this.computeSlotTemplate(template, ctx);
+            viewSet = this.computeSlotTemplate(template, {
+              ...ctx,
+              env,
+            });
           }
 
           if (template instanceof t.FragmentTemplate) {
-            viewSet = this.computeFragmentTemplate(template, ctx);
+            viewSet = this.computeFragmentTemplate(template, {
+              ...ctx,
+              env,
+            });
           }
 
           const cachedViewSet = viewSet.map((view) => {
@@ -401,10 +415,7 @@ export class Evaluator {
     if (!template.each) {
       this.tplToEachComputationCache.delete(template);
 
-      return renderTemplate(template, {
-        ...ctx,
-        env: ctx.env.inherit(),
-      });
+      return renderTemplate(template, ctx);
     }
 
     this.tplKeyToViewComputationCache.delete(baseKey);