-
Notifications
You must be signed in to change notification settings - Fork 18
Add a prominent deprecation notice #63
Add a prominent deprecation notice #63
Conversation
Perhaps the "Upgrading from sorin-ionescu/prezto" section should be removed as well? |
The notice is pretty hard to miss. I think those upgrade instructions are useful as historical reference. People who followed them before may come to look for them, wondering, what commands did I run again?? I could add a second clarifying note, if you think folks legitimately will be confused. |
No I suppose that makes sense. :) |
Maybe we should put how to reset back to sorin-ionescu/prezto in the deprecation notice?
Though that might cause conflicts, so we might want to fix that before doing it... |
Hmmm. I wouldn't expect those instructions to work. They'd preserve the commits from the fork, not to mention cause a million merge conflicts. Have you tested them? If we can develop some instructions that are tested and safe, I'd love to include them. They could also be added at a later time. |
Perhaps moving |
+1 I agree that we should give some type of indication on how to reset back. Has anyone tried to change the remote repo and just do a |
so far i had to move and redo the install myself. |
A hard reset would risk losing local commits into the ether of the git reflog, as well as losing uncommitted changes. I'd be more comfortable with a backup and reinstall. |
Not sure if it's been discussed already, and it would probably break things even more than what's being discussed here for people that have switched to this fork, but… I think @sorin-ionescu expressed some interest in sorin-ionescu#1239 (comment) toward moving the prezto project to the zsh-users organization. I like seeing projects that start as a personal repo on GH move to an organization. To me, it's often a sign that the project has some maturity and a community of some kind behind it. |
I'd like to get this notice in sooner rather than later... once it goes in, someone can open a new PR and debate about the best way for people to migrate back. |
Agreed. @johnpneumann could you mark it approved? I can't merge it until you do. |
Approved |
@cottser I spoke of my past misdeeds. I don't want to move it at the moment but get long-living issues fixed. I have added contributors. |
@belak has started merging contributions at the original repo! 🚀
So, it's time to deprecate this fork. Here's a prominent notice sending people back to the original.