Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POM-77] feat: 주문 목록 가져오기 service 구현, 테스트 작성 #29

Merged
merged 6 commits into from
Sep 14, 2023
Merged

[POM-77] feat: 주문 목록 가져오기 service 구현, 테스트 작성 #29

merged 6 commits into from
Sep 14, 2023

Conversation

choi5798
Copy link
Collaborator

📌 과제 설명

  • 사장은 오늘의 주문 목록을 가져올 수 있다
  • 테스트 포함

@choi5798 choi5798 self-assigned this Sep 14, 2023
juno-junho
juno-junho approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@juno-junho juno-junho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/test/java/com/ray/pominowner/orders/service/OrderDbTest.java Outdated

@Transactional
@SpringBootTest
public class OrderDbTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

springbootTest안에 transactional이 있어서 별도로 달 필요 없어요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 어떤 어노테이션에 transactional 이 들어있나요? (진짜 모름)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 DataJpa랑 착각했네요

hyeon-z
hyeon-z approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/test/java/com/ray/pominowner/orders/service/OrderDbTest.java Outdated
Comment on lines 35 to 36
.storeId(1L)
.build();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order생성할 때 paymentId도 넣어야할 것 같습니다!

src/test/java/com/ray/pominowner/orders/service/OrderDbTest.java Outdated

@Transactional
@SpringBootTest
public class OrderDbTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrderService의 코드를 테스트하는 건데 OrderDbTest라는 네이밍이 의도가 모호한 것 같아서 예를 들어 OrderServiceBootTest와 같이 OrderSerivce가 들어가는 이름은 어떨까요?

Juhongseok
Juhongseok approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Juhongseok Juhongseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

beomukim
beomukim approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@beomukim beomukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣

@choi5798 choi5798 merged commit fa2e5eb into dev Sep 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juno-junho juno-junho juno-junho approved these changes

@hyeon-z hyeon-z hyeon-z approved these changes

@Juhongseok Juhongseok Juhongseok approved these changes

@beomukim beomukim beomukim approved these changes

@ddongpuri ddongpuri Awaiting requested review from ddongpuri

Assignees

@choi5798 choi5798

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@choi5798 @hyeon-z @juno-junho @Juhongseok @beomukim