[POM-84] feat: 주문 거절 시 결제 취소 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeon-z
requested review from
choi5798,
juno-junho,
Juhongseok,
beomukim and
ddongpuri
Juhongseok
reviewed
Sep 14, 2023
Comment on lines
28
to
33
| Payment canceled = Payment.builder() | ||
| .id(paymentId) | ||
| .amount(payment.getAmount()) | ||
| .provider(payment.getProvider()) | ||
| .status(PaymentStatus.CANCELLED) | ||
| .build(); |
There was a problem hiding this comment.
choi5798
approved these changes
Sep 14, 2023
| public Payment create(Payment payment) { | ||
| return paymentRepository.save(payment); | ||
| } | ||
|
|
||
|
|
||
| public Payment canceled(Long paymentId) { |
There was a problem hiding this comment.
메소드이름이 동사 과거형인게 조금 부자연스러워 보여요. 현재형으로 바꾸거나 목적어를 추가하는 건 어떠신가요?
There was a problem hiding this comment.
| public void successCancelPayment() { | ||
| // given | ||
| Payment saved = new Payment(1L, 1000, PaymentStatus.COMPLETE, PGType.TOSS); | ||
| Payment canceled = new Payment(1L, 1000, PaymentStatus.CANCELLED, PGType.TOSS); |
There was a problem hiding this comment.
status의 cancelled 와 변수명 canceled을 통일하면 좋을 것 같아요
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 구현 설명
주문 거절 시 결제 취소
👩💻 요구 사항과 구현 내용
주문이 거절되는 경우 해당 결제 건의
status를CANCELED로 변경한다.