[TLVB-236] 로그인 api 시큐리티 적용 #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 6 files ±0 6 suites ±0 1s ⏱️ ±0s Results for commit e098be0. ± Comparison against base commit 559e4ae. This pull request removes 3 tests. |
ksy90101
reviewed
Jan 23, 2022
| this.userConverter = userConverter; | ||
| } | ||
|
|
||
| @SneakyThrows |
ksy90101
reviewed
Jan 23, 2022
| userDetails.getAuthorities().stream().map(GrantedAuthority::getAuthority).toList() | ||
| ); | ||
|
|
||
| response.setHeader("X-AUTH-TOKEN", token); |
There was a problem hiding this comment.
X-AUTH-TOKEN 이 값을 상수로 할 수 있도록 하면 어떨까요?
There was a problem hiding this comment.
JwtProperty 클래스에 변수(HEADER_STRING)로 추가 해도 좋을 것 같슴다ㅏㅏ!!
ksy90101
reviewed
Jan 23, 2022
| @@ -303,67 +295,6 @@ void updateUserUsingDuplicatedNicknameTest() { | |||
| verify(userRepository).existsByNickname(updateRequest.getNickname()); | |||
| } | |||
|
|
|||
| @Test | |||
| void loginSuccessTest() { | |||
There was a problem hiding this comment.
시큐리티로 변경했으니 그거에 맞춰서 테스트 코드를 작성해보세요 :)
dia312
approved these changes
Jan 24, 2022
Comment on lines
+65
to
+67
| "/api-docs", | ||
| "/webjars/**", | ||
| "/h2-console/**"); |
| userDetails.getAuthorities().stream().map(GrantedAuthority::getAuthority).toList() | ||
| ); | ||
|
|
||
| response.setHeader("X-AUTH-TOKEN", token); |
There was a problem hiding this comment.
JwtProperty 클래스에 변수(HEADER_STRING)로 추가 해도 좋을 것 같슴다ㅏㅏ!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
🤔 PR 포인트 & 궁금한 점
관련 이슈
TLVB-236