[TLVB-225] 리뷰, 좋아요 레퍼지토리, 서비스, 컨트롤러 테스트 코드 작성 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ksy90101
reviewed
Feb 23, 2022
| @WithSecurityContext(factory = WithMockAuthUserSecurityContextFactory.class) | ||
| public @interface WithMockAuthUser { | ||
|
|
||
| long id() default 1L; |
ksy90101
reviewed
Feb 24, 2022
| event.getId()); | ||
|
|
||
| // then | ||
| assertThat(searchedEventLike).isPresent(); |
ksy90101
reviewed
Feb 24, 2022
Comment on lines
+107
to
+108
| assertThat(savedReview.getDescription()).isEqualTo(review.getDescription()); | ||
| assertThat(savedReview.getPictureUrl()).isEqualTo(review.getPictureUrl()); |
ksy90101
reviewed
Feb 24, 2022
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| user = User.builder() |
There was a problem hiding this comment.
프로젝트가 거대해지면서 테스트에 대해서 중복코드가 굉장히 많아 지죠 :)
TestFixture라는걸 한번 적용해보면 어떠신가요?
There was a problem hiding this comment.
오 한번 적용해보겠습니다!! Fixture 클래스에 static 변수로 객체 생성해놓고 사용하면 코드가 많이 깔끔해지겠네용 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
🤔 PR 포인트 & 궁금한 점
관련 이슈
TLVB-225