Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: works for latest pint #187

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: works for latest pint #187

merged 4 commits into from
Dec 12, 2023

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Dec 12, 2023

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a .rst file in the directory changelog_unreleased added - remember to include a * to make it a bullet point

Description

Closes: #186

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5e5d91) 97.16% compared to head (77f96ef) 97.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          34       34           
  Lines        3102     3102           
=======================================
  Hits         3014     3014           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikapfl mikapfl merged commit 1c42e29 into primap-community:main Dec 12, 2023
10 checks passed
@mikapfl mikapfl deleted the new-pint branch December 12, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pint and np.nan again
1 participant