-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category conversion #269
Changes from 32 commits
952d9ac
2e5bb70
2afb274
000dfc1
8b9b86f
f4cc526
506d0a9
fdbec61
1ecee18
a7a1d9c
1a2f2ba
7e66953
a76feea
8bf3e02
91f9b76
80e87f0
0849805
e88f760
57c8a5f
b9973cd
4e1bb85
77f7b16
920999c
69c637b
113abda
7428d51
868afbc
4ea5398
44c2cae
7ffe506
0db7373
adb202c
b896f64
e62291d
bd9b91d
1b714fd
73ce959
2f8a35c
c90bb01
fffb84a
4b9bf2b
86aec44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# references: non_annex1_data repo | ||
# last_update: 2024-10-14 | ||
BURDI,IPCC2006_PRIMAP,comment | ||
1,1 | ||
1.A,1.A | ||
1.A.1,1.A.1 | ||
1.A.2,1.A.2 | ||
1.A.3,1.A.3 | ||
1.A.4,1.A.4 | ||
1.A.5,1.A.5 | ||
1.B,1.B | ||
1.B.1,1.B.1 | ||
1.B.2,1.B.2 | ||
2 + 3,2 | ||
2.A,2.A | ||
2.B + 2.E,2.B | ||
2.C,2.C | ||
2.F,2.F | ||
2.G + 2.D, 2.H | ||
3,2.D | ||
4,M.AG | ||
4.A,3.A.1 | ||
4.B,3.A.2 | ||
4.C,3.C.7 | ||
4.D + 4.C + 4.E + 4.F + 4.G,3.C | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to also map 4.D to single category, else we have some of the 3.C subcategories but not all which can lead to confusion and problems in category aggregation and consistency checks. I would add an M-category to IPCC2006_PRIMAP There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok thanks. I will take this to another PR. And maybe move it to climate categories, because this is where the conversion will live. |
||
4.E,3.C.1.c | ||
4.F,3.C.1.b | ||
4.G,3.C.8 | ||
5,M.LULUCF | ||
6,4 | ||
6.A,4.A | ||
6.B,4.D | ||
6.C,4.C | ||
6.D,4.E | ||
24540,0 | ||
15163,M.0.EL | ||
14637,M.BK | ||
14424,M.BK.A | ||
14423,M.BK.M, leaving 14638 --> M.BIO out for now, as it's not in climate categories | ||
7,5, 5.A-D ignored as not fitting 2006 cats |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: A | ||
title: Simple Categorization | ||
comment: A simple example categorization without relationships between categories | ||
references: doi:00000/00000 | ||
institution: PIK | ||
last_update: 2021-02-23 | ||
hierarchical: no | ||
version: 1 | ||
categories: | ||
1: | ||
title: Category 1 | ||
comment: The first category | ||
alternative_codes: | ||
- A | ||
- CatA | ||
info: | ||
important_data: | ||
- A | ||
- B | ||
- C | ||
other_important_thing: ABC | ||
2: | ||
title: Category 2 | ||
comment: The second category | ||
alternative_codes: | ||
- B | ||
- CatB | ||
3: | ||
title: Category 3 | ||
comment: The third category | ||
alternative_codes: | ||
- C | ||
- CatC | ||
unnumbered: | ||
title: The unnumbered category |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: B | ||
title: Simple Categorization | ||
comment: A simple example categorization without relationships between categories | ||
references: doi:00000/00000 | ||
institution: PIK | ||
last_update: 2021-02-23 | ||
hierarchical: no | ||
version: 1 | ||
categories: | ||
1: | ||
title: Category 1 | ||
comment: The first category | ||
alternative_codes: | ||
- A | ||
- CatA | ||
info: | ||
important_data: | ||
- A | ||
- B | ||
- C | ||
other_important_thing: ABC | ||
2: | ||
title: Category 2 | ||
comment: The second category | ||
alternative_codes: | ||
- B | ||
- CatB |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# references: test | ||
# last_update: 2024-10-14 | ||
A,B,comment | ||
1,1, no comment | ||
2+3,2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JGuetschow does the
BURDI
toIPCCC2006_PRIMAP
conversion make sense to you? I took took the rules from the config in the UNFCCC_non-AnnexI_data repo. The rules here combine the mapping and aggregation step. However we still need some aggregation after the conversion, for example for"3": {"sources": ["M.AG", "M.LULUCF"]
. That's beyond the scope of what the conversion should do if I remember correctly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add
4 + 5, 3
as a rule to aggregate AFOLU as you already do the same for 2 and 3. I think we just wanted to exclude downscaling, not aggregation.