Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove input and output weights from convert function #282

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

crdanielbusch
Copy link
Collaborator

@crdanielbusch crdanielbusch commented Oct 28, 2024

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a {pr}.thing.md file in the directory changelog added - see changelog/README.md for details

Description

This pull request builds on #281 which should be merged first. Removes the input_weights and output_weights from the convert function and raise errors if downscaling would be necessary.

At this point only one-to-one, and many-to-one conversions are possible.

In #284 support for one-to-many conversions is added again.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.80%. Comparing base (bd02bd3) to head (ae21fe8).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
primap2/_convert.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   96.98%   96.80%   -0.18%     
==========================================
  Files          49       49              
  Lines        4603     4598       -5     
==========================================
- Hits         4464     4451      -13     
- Misses        139      147       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crdanielbusch crdanielbusch self-assigned this Oct 29, 2024
@crdanielbusch crdanielbusch mentioned this pull request Oct 31, 2024
3 tasks
Base automatically changed from remove-sum-rule to main November 1, 2024 12:33
Copy link
Contributor

@JGuetschow JGuetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@crdanielbusch crdanielbusch marked this pull request as ready for review November 7, 2024 15:33
@crdanielbusch crdanielbusch merged commit f61c745 into main Nov 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants