Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one to many mapping #291

Merged
merged 13 commits into from
Nov 11, 2024
Merged

one to many mapping #291

merged 13 commits into from
Nov 11, 2024

Conversation

crdanielbusch
Copy link
Collaborator

@crdanielbusch crdanielbusch commented Nov 11, 2024

Pull request

Re-opening #284 because I merged it into the wrong branch.

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a {pr}.thing.md file in the directory changelog added - see changelog/README.md for details

Description

Please provide a short description what your pull request does.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.66%. Comparing base (ae21fe8) to head (3da2728).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
primap2/tests/test_convert.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   96.80%   96.66%   -0.14%     
==========================================
  Files          49       49              
  Lines        4598     4619      +21     
==========================================
+ Hits         4451     4465      +14     
- Misses        147      154       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crdanielbusch crdanielbusch merged commit fcdaf32 into main Nov 11, 2024
17 checks passed
@crdanielbusch crdanielbusch deleted the 1-to-n-mapping branch November 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant