Merge pull request #433 from primitivefinance/fix/normal-strategy-hook

fix(afterCreate): adds return true to afterCreate hook
primitivefinance · Aug 10, 2023 · 47d1e0b · 47d1e0b
2 parents 81fd335 + e96e633
commit 47d1e0b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/contracts/Portfolio.sol b/contracts/Portfolio.sol
@@ -754,7 +754,9 @@ contract Portfolio is ERC1155, IPortfolio {
         _getLastPoolId = poolId;
 
         // This call also prevents accidently creating a pool with an invalid strategy target address.
-        IStrategy(getStrategy(poolId)).afterCreate(poolId, strategyArgs);
+        bool success =
+            IStrategy(getStrategy(poolId)).afterCreate(poolId, strategyArgs);
+        if (!success) revert Portfolio_AfterCreateFail();
 
         emit CreatePool(
             poolId,

diff --git a/contracts/libraries/PortfolioLib.sol b/contracts/libraries/PortfolioLib.sol
@@ -9,6 +9,7 @@ import "./ConstantsLib.sol" as ConstantsLib;
 import "./PoolLib.sol";
 import "./SwapLib.sol";
 
+error Portfolio_AfterCreateFail();
 error Portfolio_BeforeSwapFail();
 error Portfolio_DuplicateToken();
 error Portfolio_Insolvent(address token, int256 net);

diff --git a/contracts/strategies/NormalStrategy.sol b/contracts/strategies/NormalStrategy.sol
@@ -74,6 +74,8 @@ contract NormalStrategy is INormalStrategy {
             durationSeconds: config.durationSeconds,
             isPerpetual: config.isPerpetual
         });
+
+        return true;
     }
 
     /// @inheritdoc IStrategy