AWS Lambda Auth0 Authentication Example using Webpack #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README, added cert.pem, improved webpack config.
patoncrispy
changed the title
marktani
reviewed
Jul 24, 2017
| * @memberof GraphcoolService | ||
| */ | ||
| async getUser(userId) { | ||
| const query = ` |
There was a problem hiding this comment.
GH and tabs are weird. Please replace all tabs with spaces 🙂
|
This looks fantastic, I like the certificate approach. One minor adjustment that you could make is to replace tabs with spaces (I know, I know). Also I'm thinking of a different folder structure for all examples. I'll do that once this PR is merged 🙂 |
|
Cool! Will make those changes later. :) |
|
I would consider using the Auth0 JWKS endpoint (https://{auth0domain}/.well-known/jwks.json) instead of manually downloading the signing certificate in order to validate the token. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marktani, this is my example, that we discussed. I haven't added any client application for it, but as it's just the Lambda function that differs, the client in the original example should work perfectly fine.
I've added as much relevant information as I can think of in the README and the code is pretty thoroughly documented.
Let me know what you think! Let me know if you spot any issues or would like something amended/added.