Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addtolist_es6.js #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions emails-and-notifications/sendgrid-email/addtolist_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,23 @@ module.exports = (event) => {

return new Promise((resolve, reject) => {
let request = sg.emptyRequest()

// add SG custom fields here
const { email, nameFirst: first_name, nameLast: last_name } = event.data.User.node
request.body = [{ email, first_name, last_name }]
request.method = "POST"
request.path = "/v3/contactdb/recipients"

callAPI(request).then(response => {
// this call creates a new recipient in Sendgrid
// and adds it to the global list "All contacts"
callAPI(sg, request).then(response => {

// this call adds newly created recipient to a specific list (not required)
let request = sg.emptyRequest()
request.method = 'POST'
request.path = '/v3/contactdb/lists/___SENDGRID_LIST_ID___/recipients/' + response.body.persisted_recipients[0]

callAPI(request)
callAPI(sg, request)
Copy link
Contributor

@kbrandwijk kbrandwijk Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just move the sg declaration (line 3) out of the function, instead of passing it around?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could indeed, tbh I just wanted to push a quick fix for the repo and myself

.then(response => resolve(response))
.catch(error => reject(error))
})
Expand Down