Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve api reference docs for pulse return types #6097

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

nikolasburk
Copy link
Member

No description provided.

Copy link
Contributor

Absolute URL check

No absolute URLs to prisma.io/docs found.

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link
Contributor

Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bffc29e
Status: ✅  Deploy successful!
Preview URL: https://f319cf98.docs-51g.pages.dev
Branch Preview URL: https://misc-pulse-return-types.docs-51g.pages.dev

View logs

@nikolasburk nikolasburk requested a review from janpio June 12, 2024 08:34
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am just not smart enough, but here is my feedback that this might be to complicated for me: https://prisma-company.slack.com/archives/C053YT1U9M0/p1718183855095329?thread_ts=1718127951.708439&cid=C053YT1U9M0

@nikolasburk nikolasburk merged commit 0d44898 into main Jun 17, 2024
8 of 10 checks passed
@nikolasburk nikolasburk deleted the misc/pulse-return-types branch June 17, 2024 08:52
@nikolasburk
Copy link
Member Author

Merged as is @janpio since this seems to be the most natural way to display TS typings. Let's see if we get further feedback for this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants