Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak display of code in headings #6103

Merged
merged 4 commits into from
Jun 14, 2024
Merged

tweak display of code in headings #6103

merged 4 commits into from
Jun 14, 2024

Conversation

jharrell
Copy link
Member

@jharrell jharrell commented Jun 13, 2024

Resolves DA-349

@jharrell jharrell self-assigned this Jun 13, 2024
Copy link
Contributor

Absolute URL check

No absolute URLs to prisma.io/docs found.

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link

cloudflare-workers-and-pages bot commented Jun 13, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0dcaec4
Status: ✅  Deploy successful!
Preview URL: https://74f38ed4.docs-51g.pages.dev
Branch Preview URL: https://fix-inline-code.docs-51g.pages.dev

View logs

@janpio
Copy link
Contributor

janpio commented Jun 13, 2024

Definitely improves it for the "bigger" headlines, but for smaller ones the padding is now "missing" that makes the grey background detectable visually. For example on https://fix-inline-code.docs-51g.pages.dev/about/docs-components/frontmatter

@janpio
Copy link
Contributor

janpio commented Jun 13, 2024

Another example where it is now a bit too little:
image
(left old, right new)

@jharrell jharrell merged commit f8b5f64 into main Jun 14, 2024
8 of 10 checks passed
@jharrell jharrell deleted the fix/inline-code branch June 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants