Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting started improvements #6183

Merged
merged 24 commits into from
Aug 9, 2024
Merged

getting started improvements #6183

merged 24 commits into from
Aug 9, 2024

Conversation

nikolasburk
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Aug 7, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bff1c78
Status: ✅  Deploy successful!
Preview URL: https://30b24176.docs-51g.pages.dev
Branch Preview URL: https://gse-improvements.docs-51g.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Absolute URL check

No absolute URLs to prisma.io/docs found.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

/accelerate/what-is-accelerate /docs/##( TODO: Path of page that replaces deleted page )##
/pulse/what-is-pulse /docs/##( TODO: Path of page that replaces deleted page )##

static/_redirects Outdated Show resolved Hide resolved
tocDepth: 3
---

## Prisma Accelerate examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just link to the examples repo instead of a new page, what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to place an external link in the sidenav? I think this isn't possible... I had this exact convo a while back already but back then the conclusion was that it's not possible; maybe this has changed with Docusaurus though?

cc @jharrell @carlagn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea i disagree with putting an external link in the side nav. Also I think having the examples be in the docs allows us more flexibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmh, okay. I indeed would've preferred just an external link. What flexibility do we gain here that's valuable?

content/100-getting-started/01-quickstart.mdx Outdated Show resolved Hide resolved
content/100-getting-started/01-quickstart.mdx Show resolved Hide resolved
static/_redirects Show resolved Hide resolved
tocDepth: 3
---

## Prisma Accelerate examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea i disagree with putting an external link in the side nav. Also I think having the examples be in the docs allows us more flexibility.

static/_redirects Show resolved Hide resolved
static/_redirects Outdated Show resolved Hide resolved
@nikolasburk nikolasburk merged commit b1c0138 into main Aug 9, 2024
8 of 10 checks passed
@nikolasburk nikolasburk deleted the gse/improvements branch August 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants