Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about directUrl not needed while using Prisma Postgres #6466

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

nurul3101
Copy link
Member

No description provided.

@nurul3101 nurul3101 requested a review from ankur-arch November 29, 2024 15:07
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link

cloudflare-workers-and-pages bot commented Nov 29, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2b9b3e
Status: ✅  Deploy successful!
Preview URL: https://414c434c.docs-51g.pages.dev
Branch Preview URL: https://nurul3101-patch-5.docs-51g.pages.dev

View logs

@ankur-arch ankur-arch assigned ankur-arch and nurul3101 and unassigned ankur-arch Nov 29, 2024
@ankur-arch ankur-arch merged commit bb66bf6 into main Dec 2, 2024
9 of 11 checks passed
@ankur-arch ankur-arch deleted the nurul3101-patch-5 branch December 2, 2024 15:31
Comment on lines +75 to +77
:::note
If you are using Prisma with PostgreSQL, there is no need for `directUrl`, as Prisma Migrate and Introspection work with the `prisma+postgres://` connection string.
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the impulse of mentioning this here but I think it's out-of-context in the Accelerate "getting started" guide.

Suggested change
:::note
If you are using Prisma with PostgreSQL, there is no need for `directUrl`, as Prisma Migrate and Introspection work with the `prisma+postgres://` connection string.
:::

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it here because the customers were referring to Accelerate guide while using Prisma Postgres. Do you think I should add it in Prisma Postgres docs section instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants