Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optimize recommendation to avoid current_time #6550

Merged
merged 4 commits into from
Jan 9, 2025
Merged

feat: add optimize recommendation to avoid current_time #6550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5aad67c
feat: add optimize recommendation to avoid current_time
ankur-arch Dec 26, 2024
f636312
fix: spelling mistakes
ankur-arch Dec 26, 2024
f3ea7df
Merge branch 'main' into current_time
jharrell Jan 9, 2025
7527d73
Merge branch 'main' into current_time
jharrell Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions content/700-optimize/300-recordings.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ When a recording session ends, Optimize generates recommendations such as:
- [Using `@db.Char(n)`](/optimize/recommendations/avoid-char)
- [Using `@db.VarChar(n)`](/optimize/recommendations/avoid-varchar)
- [Using `timestamp(0)` or `timestamptz(0)`](/optimize/recommendations/avoid-timestamp-timestampz-0)
- [Using `CURRENT_TIME`](/optimize/recommendations/current-time)
- [Storing large objects or BLOBs in the database](/optimize/recommendations/storing-blob-in-database)
- [Indexing on unique columns](/optimize/recommendations/indexing-on-unique-columns)
- [Long-running transactions](/optimize/recommendations/long-running-transactions)
Expand Down
17 changes: 17 additions & 0 deletions content/700-optimize/400-recommendations/1000-current-time.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
title: 'Using CURRENT_TIME'
metaTitle: 'Optimize Recommendations: Avoid usage of `CURRENT_TIME`'
metaDescription: 'Learn about the recommendation provided by Optimize for using the `CURRENT_TIME` function'
tocDepth: 2
toc: true
---

The following raw SQL query uses the `CURRENT_TIME` function:

```ts
prisma.$queryRaw`SELECT CURRENT_TIME;`
```

### Why this is a problem

The `CURRENT_TIME` keyword returns only the time (e.g., 14:30:00) without a date, making it unsuitable for tasks like logging or generating timestamps that require precise event tracking. It returns a value of type `timetz`, which was added for SQL standard compatibility but is generally discouraged.
Loading