Skip to content

Commit

Permalink
qe: Fix neon tests after 0.7.0 update (#4647)
Browse files Browse the repository at this point in the history
Due to the way our dependencies are structured, we end up with 2 copies
of neon if client have incompatible versions:
- dev dependency in client
- dependency in executor

So, global changes made to one of them do not affect another. That broke
engine's test when client updated to 0.7.0. PR updates executor
dependecy as well, which fixes the problem.

This problem is a quirk of our test setup and won't affect end users.
  • Loading branch information
Serhii Tatarintsev authored Jan 15, 2024
1 parent 1deed7d commit 0fb4ba0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions nix/shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ in
nodejs_20.pkgs.pnpm

cargo-insta
cargo-nextest
jq
graphviz
wasm-bindgen-cli
Expand Down
2 changes: 1 addition & 1 deletion query-engine/driver-adapters/executor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "Apache-2.0",
"dependencies": {
"@libsql/client": "0.3.6",
"@neondatabase/serverless": "0.6.0",
"@neondatabase/serverless": "0.7.2",
"@planetscale/database": "1.13.0",
"query-engine-wasm-latest": "npm:@prisma/query-engine-wasm@latest",
"query-engine-wasm-baseline": "npm:@prisma/[email protected]",
Expand Down

0 comments on commit 0fb4ba0

Please sign in to comment.