fix: return error instead of panicking in release_savepoint · prisma/prisma-engines@1cadd66

Commit

fix: return error instead of panicking in release_savepoint

Loading branch information

LucianBuzzo committed Jan 9, 2025

1 parent c454efc commit 1cadd66

-Original file line number
+Diff line change
@@ Expand Up / @@ -177,9 +177,9 @@ impl Transaction for DefaultTransaction<'_> { @@
             let depth_val = self.depth.load(Ordering::Relaxed);
             if depth_val == 0 {
-                panic!(
-                    "No savepoint to release in transaction, make sure to call create_savepoint before release_savepoint"
-                );
+                return Err(crate::Error::new(
+                    "No savepoint to release in transaction, make sure to call create_savepoint before release_savepoint",
+                ));
             }
             // Perform the asynchronous operation without holding the lock
@@ Expand Down @@

0 comments on commit `1cadd66`

Please sign in to comment.

Commit

There are no files selected for viewing

GitHub Actions / test

GitHub Actions / cockroach_22_1_0

GitHub Actions / postgres13

GitHub Actions / cockroach_22_2

GitHub Actions / postgres11

GitHub Actions / mysql_mariadb

GitHub Actions / test (postgres16, false, postgres, 16)

GitHub Actions / postgres10

GitHub Actions / postgres15

GitHub Actions / postgres16

GitHub Actions / mongodb42

GitHub Actions / mssql_2022

GitHub Actions / mongodb5

GitHub Actions / mssql_2019

GitHub Actions / sqlite

GitHub Actions / postgres12

GitHub Actions / postgres14

GitHub Actions / mssql_2017

GitHub Actions / cockroach_23_1

GitHub Actions / vitess_8_0

GitHub Actions / mysql_5_6

GitHub Actions / run

GitHub Actions / mongodb44

GitHub Actions / mysql_5_7

GitHub Actions / mysql_8

GitHub Actions / postgres9

GitHub Actions / schema-engine-cli on ubuntu-latest

GitHub Actions / tests (--lib --features=all-native)

GitHub Actions / React Native / Android build for commit 4bce40314bad6e6318409ef539a51e288a90e8b7

GitHub Actions / query-engine-node-api on ubuntu-latest

GitHub Actions / query-engine on ubuntu-latest

GitHub Actions / clippy linting

GitHub Actions / query-engine-node-api on windows-latest

GitHub Actions / sqlite / json query 4/4

GitHub Actions / sqlite / json query 2/4

GitHub Actions / sqlite / json query 1/4

GitHub Actions / sqlite / json query 3/4

GitHub Actions / sqlite / graphql query 1/4

GitHub Actions / sqlite / graphql query 2/4

GitHub Actions / sqlite / graphql query 4/4

GitHub Actions / sqlite / graphql query 3/4

GitHub Actions / mysql mariadb / json query 1/4

GitHub Actions / mysql mariadb / json query 4/4

GitHub Actions / mysql mariadb / json query 2/4

GitHub Actions / mysql mariadb / graphql query 2/4

GitHub Actions / mysql mariadb / graphql query 4/4

GitHub Actions / postgres 10 / graphql join 1/4

GitHub Actions / mysql mariadb / graphql query 3/4

GitHub Actions / postgres 10 / graphql join 4/4

GitHub Actions / postgres 10 / json join 2/4

GitHub Actions / postgres 10 / graphql query 2/4

GitHub Actions / postgres 10 / json query 1/4

GitHub Actions / postgres 10 / json query 4/4

GitHub Actions / postgres 10 / json join 4/4

GitHub Actions / postgres 10 / graphql query 1/4

GitHub Actions / mysql mariadb / json query 3/4

GitHub Actions / postgres 10 / graphql query 3/4

GitHub Actions / postgres 10 / json query 2/4

GitHub Actions / postgres 10 / json query 3/4

GitHub Actions / mysql 5.6 / json query 1/4

GitHub Actions / postgres 11 / json join 1/4

GitHub Actions / postgres 10 / graphql query 4/4

GitHub Actions / mysql 5.6 / graphql query 3/4

GitHub Actions / postgres 10 / json join 3/4

GitHub Actions / postgres 10 / json join 1/4

GitHub Actions / mysql 5.6 / json query 4/4

GitHub Actions / postgres 11 / graphql query 2/4

GitHub Actions / mysql 5.6 / json query 2/4

GitHub Actions / postgres 11 / graphql join 3/4

GitHub Actions / query-engine on macos-13

GitHub Actions / postgres 11 / json query 2/4

GitHub Actions / postgres 11 / json query 3/4

GitHub Actions / postgres 11 / json query 1/4

GitHub Actions / postgres 11 / json join 4/4

GitHub Actions / postgres 11 / graphql query 1/4

GitHub Actions / postgres 12 / graphql join 3/4

GitHub Actions / postgres 12 / graphql join 2/4

GitHub Actions / mysql 5.6 / graphql query 1/4