-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(driver-adapters): fix bigint handling on creation and filter #4648
Conversation
WASM Size
|
✅ WASM query-engine: no benchmarks have regressedFull benchmark report
After changes in 57c5acb |
CodSpeed Performance ReportMerging #4648 will not alter performanceComparing Summary
|
Note: |
I understood the problem, for which I don't have yet a solution: on PlanetScale, bigint values are placed into queries as strings, resulting in SQL snippets like
which obviously trigger syntax errors. |
Interesting. Should we report it to planetscale maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests are green.
Maybe, skip Plantescale tests back and open follow-up issue?
Yeah, I'm thinking the same. I've created https://github.com/prisma/team-orm/issues/836, and excluded PlanetScale. I'll let the CI run, and merge afterwards if it's all good |
PlanetScale still failing, I'll keep exploring why. |
Needs #4648 to be merged into main before, but all raw queries isses are already fixed either by me or Alberto, so we have to just unskip the tests. Close prisma/team-orm#659
I've opened a PR on PlanetScale to fix this: planetscale/database-js#159. |
…g for upstream PR to be merged
Needs #4648 to be merged into main before, but all raw queries isses are already fixed either by me or Alberto, so we have to just unskip the tests. Close prisma/team-orm#659
This PR closes https://github.com/prisma/team-orm/issues/656 and https://github.com/prisma/team-orm/issues/836.
Please read this comment.