Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load .envrc.local before running nix #4652

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Load .envrc.local before running nix #4652

merged 1 commit into from
Jan 17, 2024

Conversation

miguelff
Copy link
Contributor

Makes it possible to disable nix by adding the DISABLE_NIX env var in .envrc.local

@miguelff miguelff requested a review from a team as a code owner January 17, 2024 11:53
@miguelff miguelff requested review from laplab and Weakky and removed request for a team January 17, 2024 11:53
Copy link
Contributor

WASM Size

Engine This PR Base branch Diff
WASM 2.719MiB 2.719MiB 0.000B
WASM (gzip) 1.002MiB 1.002MiB 0.000B

Copy link
Contributor

🚨 WASM query-engine: 2 benchmark(s) have regressed at least 2%

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.19.0 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - 25000)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  307.11 ms/iter (304.31 ms … 312.49 ms) 307.12 ms 312.49 ms 312.49 ms
Web Assembly: Latest    312.97 ms/iter  (308.7 ms … 337.82 ms) 311.33 ms 337.82 ms 337.82 ms
Web Assembly: Current   310.14 ms/iter (307.06 ms … 315.13 ms)  311.9 ms 315.13 ms 315.13 ms
Node API: Current       242.48 ms/iter (229.08 ms … 254.47 ms) 246.73 ms 254.47 ms 254.47 ms

summary for movies.findMany() (all - 25000)
  Web Assembly: Current
   1.28x slower than Node API: Current
   1.01x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   12.64 ms/iter   (11.89 ms … 17.33 ms)  12.71 ms  17.33 ms  17.33 ms
Web Assembly: Latest     12.45 ms/iter   (12.04 ms … 16.59 ms)  12.34 ms  16.59 ms  16.59 ms
Web Assembly: Current    13.01 ms/iter   (11.88 ms … 22.84 ms)  12.51 ms  22.84 ms  22.84 ms
Node API: Current         9.31 ms/iter     (9.13 ms … 9.68 ms)   9.32 ms   9.68 ms   9.68 ms

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   1.4x slower than Node API: Current
   1.05x slower than Web Assembly: Latest
   1.03x slower than Web Assembly: Baseline

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    2.06 ms/iter     (1.86 ms … 9.04 ms)   1.96 ms   3.44 ms   3.46 ms
Web Assembly: Latest      2.01 ms/iter      (1.83 ms … 3.8 ms)   1.94 ms   3.36 ms    3.6 ms
Web Assembly: Current     1.93 ms/iter     (1.83 ms … 3.18 ms)   1.91 ms   2.77 ms   2.86 ms
Node API: Current         1.56 ms/iter     (1.47 ms … 2.08 ms)   1.58 ms    1.8 ms   2.04 ms

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   1.24x slower than Node API: Current
   1.04x faster than Web Assembly: Latest
   1.07x faster than Web Assembly: Baseline

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   12.13 ms/iter   (11.88 ms … 12.61 ms)  12.19 ms  12.61 ms  12.61 ms
Web Assembly: Latest     12.23 ms/iter   (11.99 ms … 12.83 ms)  12.31 ms  12.83 ms  12.83 ms
Web Assembly: Current    12.39 ms/iter   (11.92 ms … 16.07 ms)  12.35 ms  16.07 ms  16.07 ms
Node API: Current         9.55 ms/iter    (9.22 ms … 10.48 ms)   9.62 ms  10.48 ms  10.48 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.3x slower than Node API: Current
   1.02x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    1.89 ms/iter     (1.83 ms … 3.22 ms)   1.89 ms   2.28 ms    2.9 ms
Web Assembly: Latest      1.91 ms/iter     (1.82 ms … 2.97 ms)   1.89 ms   2.84 ms   2.86 ms
Web Assembly: Current     1.89 ms/iter     (1.83 ms … 3.08 ms)   1.88 ms   2.33 ms   2.46 ms
Node API: Current         1.61 ms/iter      (1.5 ms … 5.06 ms)    1.6 ms    1.8 ms   2.13 ms

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.18x slower than Node API: Current
   1x faster than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   12.25 ms/iter    (11.9 ms … 16.59 ms)  12.25 ms  16.59 ms  16.59 ms
Web Assembly: Latest     12.27 ms/iter   (12.01 ms … 17.51 ms)  12.21 ms  17.51 ms  17.51 ms
Web Assembly: Current    12.13 ms/iter   (11.84 ms … 12.56 ms)  12.21 ms  12.56 ms  12.56 ms
Node API: Current         9.51 ms/iter    (9.08 ms … 10.03 ms)   9.65 ms  10.03 ms  10.03 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.28x slower than Node API: Current
   1.01x faster than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    1.92 ms/iter     (1.82 ms … 5.85 ms)    1.9 ms   2.53 ms   2.94 ms
Web Assembly: Latest      1.89 ms/iter     (1.81 ms … 2.93 ms)   1.89 ms   2.36 ms   2.83 ms
Web Assembly: Current     2.03 ms/iter     (1.83 ms … 3.23 ms)   1.91 ms   3.08 ms   3.11 ms
Node API: Current          1.6 ms/iter     (1.53 ms … 1.85 ms)   1.61 ms   1.84 ms   1.85 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.27x slower than Node API: Current
   1.07x slower than Web Assembly: Latest
   1.06x slower than Web Assembly: Baseline

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  938.59 µs/iter    (858.65 µs … 3.7 ms)  923.6 µs   1.45 ms   1.52 ms
Web Assembly: Latest    927.79 µs/iter   (872.57 µs … 1.56 ms) 919.63 µs   1.51 ms   1.53 ms
Web Assembly: Current   940.36 µs/iter   (884.42 µs … 1.62 ms) 929.25 µs   1.45 ms   1.55 ms
Node API: Current        815.7 µs/iter   (763.81 µs … 1.07 ms) 832.76 µs 991.29 µs   1.03 ms

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.15x slower than Node API: Current
   1.01x slower than Web Assembly: Latest
   1x faster than Web Assembly: Baseline

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  926.11 µs/iter   (865.13 µs … 1.46 ms) 926.76 µs   1.33 ms   1.39 ms
Web Assembly: Latest    910.72 µs/iter   (859.09 µs … 1.26 ms) 914.48 µs   1.21 ms   1.23 ms
Web Assembly: Current   916.85 µs/iter   (868.53 µs … 1.44 ms) 918.16 µs    1.2 ms   1.42 ms
Node API: Current       831.42 µs/iter   (769.97 µs … 1.22 ms) 865.82 µs   1.02 ms   1.04 ms

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.1x slower than Node API: Current
   1.01x slower than Web Assembly: Latest
   1.01x faster than Web Assembly: Baseline

After changes in de475d8

Copy link

codspeed-hq bot commented Jan 17, 2024

CodSpeed Performance Report

Merging #4652 will not alter performance

Comparing mff/envrc (de475d8) with main (71726cc)

Summary

✅ 11 untouched benchmarks

@miguelff miguelff merged commit b157f36 into main Jan 17, 2024
136 of 139 checks passed
@miguelff miguelff deleted the mff/envrc branch January 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants