New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Refactor relation aggregation selection #4657

Closed

aqrln wants to merge 2 commits into main from refactor-relation-count

Member

aqrln commented Jan 18, 2024 •

edited

Loading

Closes https://github.com/prisma/team-orm/issues/815

On hold for now, the scope seems to be bigger than anticipated.

Next steps:

Fix all the write queries that return RecordSelection
Rework serialize_objects and serialize_objects_with_relations
Remove commented-out code
Remove dead code (lots of stuff that's not commented out but not used or called anymore), overall this PR should have more removed than added lines

aqrln added 2 commits

January 18, 2024 17:57


          Refactor relation aggregation selection

8d499e7


          build user_selection and field_selection in query graph builder

b8283a7

aqrln self-assigned this

Member Author

aqrln commented Jan 22, 2024

Closing in favour of #4658. See the other PR description for next steps.

aqrln closed this

aqrln deleted the refactor-relation-count branch

January 22, 2024 20:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet