fix(qe-wasm): make traces consistent with node-api engine #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the scope of the `prisma:engine:query` span to contain both the request handler and the response serialization, identical to the Node-API engine, preventing `prisma:engine:response_json_serialization` from being orphaned outside the trace. This is a follow up to #5089.
CodSpeed Performance ReportMerging #5090 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
aqrln
changed the title
prisma:engine:query span
jkomyno
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the scope of the
prisma:engine:queryspan to contain both the request handler and the response serialization, identical to the Node-API engine, preventingprisma:engine:response_json_serializationfrom being orphaned outside the trace. This is a follow up to fix(query-engine-wasm): add response_json_serialization span #5089.Add missing future instrumentation in
start_transaction,commit_transaction,rollback_transaction.Strip traceparents from
db.query.textattribute with driver adapters as well, and not only native connectors.