Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datamodel-renderer): sort generator fields deterministically #5114

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix(datamodel-renderer): sort generator fields deterministically #5114

merged 2 commits into from
Jan 13, 2025

Conversation

FGoessler
Copy link
Contributor

This PR addresses an issue that caused generator fields to "randomly" change their ordering on prisma db pull. See prisma/prisma#17899.

@FGoessler FGoessler requested a review from a team as a code owner January 10, 2025 09:38
@FGoessler FGoessler requested review from wmadden and removed request for a team January 10, 2025 09:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.097MiB 2.097MiB 0.000B
Postgres (gzip) 841.798KiB 841.797KiB 1.000B
Mysql 2.058MiB 2.058MiB 0.000B
Mysql (gzip) 828.070KiB 828.072KiB -2.000B
Sqlite 1.973MiB 1.973MiB 0.000B
Sqlite (gzip) 792.800KiB 792.802KiB -2.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5114 will not alter performance

Comparing fix/orm-490-let-db-pull-sort-generator-fields-deterministically (dd64b7e) with main (66ff515)

Summary

✅ 11 untouched benchmarks

@FGoessler FGoessler added this to the 6.3.0 milestone Jan 10, 2025
@FGoessler FGoessler merged commit a046f87 into main Jan 13, 2025
367 checks passed
@FGoessler FGoessler deleted the fix/orm-490-let-db-pull-sort-generator-fields-deterministically branch January 13, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacek-prisma jacek-prisma jacek-prisma approved these changes

@wmadden wmadden Awaiting requested review from wmadden wmadden is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FGoessler @jacek-prisma