feat: generic query building #5127
Conversation
| #[error("{0}")] | ||
| QuaintError(#[from] quaint::error::Error), | ||
| #[error("query builder error: {0}")] | ||
| QueryBuildFailure(#[source] Box<dyn std::error::Error + Send + Sync>), |
There was a problem hiding this comment.
made the error dynamic too, it might be odd to use a dynamic query builder with non-dynamic errors, but I'm open to suggestions
|
|
||
| pub use query_arguments_ext::QueryArgumentsExt; | ||
|
|
||
| pub trait QueryBuilder { |
There was a problem hiding this comment.
this trait might need to change, it's pretty low level and makes some assumptions but I think it's an OK start
| .collect() | ||
| } else { | ||
| let partitioned_batches = partition_into_batches(args, ctx); | ||
| trace!("Total of {} batches to be executed.", partitioned_batches.len()); |
There was a problem hiding this comment.
I've removed this trace, not sure if we'll need it since this can be introspected pretty easy now that query building is separated, but I can add it back, it'll require depending on tracing in the builder crate though
CodSpeed Performance ReportMerging #5127 will degrade performances by 5.51%Comparing Summary
Benchmarks breakdown
|
WASM Query Engine file Size
|
| @@ -191,49 +167,6 @@ pub(crate) async fn create_record( | |||
| } | |||
| } | |||
|
|
|||
| /// Returns a set of fields that are used in the arguments for the create operation. | |||
| fn collect_affected_fields(args: &[WriteArgs], model: &Model) -> HashSet<ScalarFieldRef> { | |||
There was a problem hiding this comment.
moved this and one other function to the sql builder crate, might wanna sync this with main
| @@ -39,6 +39,7 @@ serial_test = "*" | |||
| quaint.workspace = true | |||
| indoc.workspace = true | |||
| indexmap.workspace = true | |||
| sql-query-builder = { path = "../query-builders/sql-query-builder" } | |||
There was a problem hiding this comment.
dev-dependency for the compiler example
There was a problem hiding this comment.
Let's move the compiler example to the top-level query-compiler crate when it's ready (not in this PR)
Implements a generic
SqlQueryBuilderfor all quaint visitors for theQueryBuildertrait, and uses theQueryBuildertrait in the compiler