Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in div_unsafe #80

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix bug in div_unsafe #80

merged 2 commits into from
Sep 12, 2023

Conversation

kitounliu
Copy link
Contributor

fix bug in div_unsafe: it should be sub not add for a

davidnevadoc
davidnevadoc approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@davidnevadoc davidnevadoc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes fix the bugs, thanks! LGTM

@davidnevadoc
Copy link
Contributor

davidnevadoc commented Sep 5, 2023 •
edited
Loading

While looking into the assert_zero bug I also looked into assert_non_zero and I believe this line :

halo2wrong/integer/src/chip.rs

Line 395 in 2367335

let a = &self.reduce_if_limb_values_exceeds_reduced(ctx, a)?;

could be removed because the reduction gets executed in the next call, here:
https://github.com/privacy-scaling-explorations/halo2wrong/blob/master/integer/src/chip/assert_not_zero.rs#L22

cc: @kilic

@kilic kilic merged commit 5233325 into privacy-scaling-explorations:master Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnevadoc davidnevadoc davidnevadoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitounliu @davidnevadoc @kilic