Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

45 add filter functionality sorting to project lib #81

Merged
merged 10 commits into from
Sep 14, 2023
Merged

45 add filter functionality sorting to project lib #81

merged 10 commits into from
Sep 14, 2023

Conversation

kalidiagne
Copy link
Collaborator

@kalidiagne kalidiagne commented Sep 6, 2023 •
edited
Loading

  • add sorting with random, title: a-z, title: z-a

Random sorting
Screenshot 2023-09-06 at 17 41 03

Z-A sorting
Screenshot 2023-09-06 at 17 41 27

A-z sorting
Screenshot 2023-09-06 at 17 41 14

@kalidiagne kalidiagne linked an issue Sep 6, 2023 that may be closed by this pull request
Add filter functionality, sorting to project lib #45
Closed
@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 7:08pm
website-v2-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 7:08pm

@ChialiT
Copy link
Contributor

ChialiT commented Sep 6, 2023

Ths sorting popup render extra empty padding for me tho,
image

@ChialiT
Copy link
Contributor

ChialiT commented Sep 7, 2023

Requested design team to update the UI, we should list out how the current view is sorted on high level.
and missing the "Relevancy" when the filter is applied.

@kalidiagne
Copy link
Collaborator Author

Requested design team to update the UI, we should list out how the current view is sorted on high level. and missing the "Relevancy" when the filter is applied.

UI for the filter updated with Sort by label, I also checked the popup in a different browser and i can not see the extra empty padding

@ChialiT
Copy link
Contributor

ChialiT commented Sep 8, 2023

Requested design team to update the UI, we should list out how the current view is sorted on high level. and missing the "Relevancy" when the filter is applied.

UI for the filter updated with Sort by label, I also checked the popup in a different browser and i can not see the extra empty padding

Padding is fixed for me.

thebeyondr
thebeyondr suggested changes Sep 8, 2023
View reviewed changes
components/project/project-result-bar.tsx Outdated Show resolved Hide resolved
state/useProjectFiltersState.ts Outdated Show resolved Hide resolved
@kalidiagne kalidiagne merged commit f19a2db into main Sep 14, 2023
1 check passed
@kalidiagne kalidiagne deleted the 45-add-filter-functionality-sorting-to-project-lib branch September 21, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeyondr thebeyondr thebeyondr approved these changes

@ChialiT ChialiT ChialiT approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer

Assignees

@kalidiagne kalidiagne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter functionality, sorting to project lib
3 participants
@kalidiagne @ChialiT @thebeyondr