Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 page #85

Merged
merged 6 commits into from
Sep 14, 2023
Merged

404 page #85

merged 6 commits into from
Sep 14, 2023

Conversation

kalidiagne
Copy link
Collaborator

Desktop
Screenshot 2023-09-08 at 11 33 55

Mobile
Screenshot 2023-09-08 at 11 34 02

@kalidiagne kalidiagne linked an issue Sep 8, 2023 that may be closed by this pull request
Develop 404 page #76
Closed
@vercel
Copy link

vercel bot commented Sep 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 8:13am
website-v2-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 8:13am

@kalidiagne
Copy link
Collaborator Author

There from here

https://website-v2-git-76-devel-fb72be-privacy-and-scaling-explorations.vercel.app/wwww

@ChialiT @thebeyondr

ChialiT
ChialiT approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ChialiT ChialiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve as it is, but we need to swap the asset.
once asset is updated, I think we are good to go.

public/icons/emotion-sad-line.svg Outdated Show resolved Hide resolved
thebeyondr
thebeyondr suggested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@thebeyondr thebeyondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new asset to replace the sad img

@kalidiagne
Copy link
Collaborator Author

new asset to replace the sad img

Asset replaced 👍

@kalidiagne kalidiagne merged commit 05be898 into main Sep 14, 2023
1 check passed
@kalidiagne kalidiagne deleted the 76-develop-404-page branch September 21, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeyondr thebeyondr thebeyondr approved these changes

@ChialiT ChialiT ChialiT approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer

Assignees

@kalidiagne kalidiagne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop 404 page
3 participants
@kalidiagne @ChialiT @thebeyondr