migrate tests to use ? instead of unwrap & experimental-frontends renaming
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
changed the title
arnaucube
changed the title
eperimental-frontends & IVC renamings
arnaucube
changed the title
eperimental-frontends & IVC renamingsexperimental-frontends & IVC renamings
…scussed in the last meeting
arnaucube
force-pushed
the
renamings
branch
2 times, most recently
from
f13a8fd to
93bde0e
Compare
arnaucube
changed the title
experimental-frontends & IVC renamingsexperimental-frontends renaming
arnaucube
changed the title
experimental-frontends renaming? instead of unwrap & experimental-frontends renaming
motivation: in this way tests are like in-library code and there is no differenciation between test code and library code in terms of style, where errors are returned with `?` instead of `unwrap`. Same for examples. This was already done partially like this in some of the ProtoGalaxy tests, now on almost all the folding-schemes tests.
arnaucube
force-pushed
the
renamings
branch
3 times, most recently
from
2d52042 to
c82405d
Compare
winderica
reviewed
Dec 4, 2024
winderica
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontendstoexperimental-frontendsto make more explicit that those are experimental and not recommended for usage, as discussed in the last meetingupper_bound_ccstocompute_concrete_ccsto describe better the method logic?instead ofunwrap. Same for examples. This was already done partially like this in some of the PrtoGalaxy tests, now on almost all the folding-schemes tests.