lint: code cleanup

privacy-scaling-explorations · Mar 25, 2024 · 036e366 · 036e366
1 parent 362abc4
commit 036e366
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 14 deletions.
diff --git a/zkevm-circuits/src/evm_circuit/execution/error_oog_call.rs b/zkevm-circuits/src/evm_circuit/execution/error_oog_call.rs
@@ -132,7 +132,6 @@ impl<F: Field> ExecutionGadget<F> for ErrorOOGCallGadget<F> {
 
         let tx_id = rws.next().call_context_value();
         let is_static = rws.next().call_context_value();
-
         let gas = rws.next().stack_value();
         let callee_address = rws.next().stack_value();
 
@@ -142,12 +141,6 @@ impl<F: Field> ExecutionGadget<F> for ErrorOOGCallGadget<F> {
             U256::zero()
         };
 
-        if is_call_or_callcode == 1 {
-            rws.offset_sub(1);
-        }
-
-        rws.offset_add(is_call_or_callcode);
-
         let cd_offset = rws.next().stack_value();
         let cd_length = rws.next().stack_value();
         let rd_offset = rws.next().stack_value();
@@ -156,9 +149,7 @@ impl<F: Field> ExecutionGadget<F> for ErrorOOGCallGadget<F> {
         rws.offset_add(1);
 
         let callee_code_hash = rws.next().account_codehash_pair().0;
-
         let callee_exists = !callee_code_hash.is_zero();
-
         let (is_warm, is_warm_prev) = rws.next().tx_access_list_value_pair();
 
         let memory_expansion_gas_cost = self.call.assign(

diff --git a/zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs b/zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs
@@ -181,9 +181,7 @@ impl<F: Field> ExecutionGadget<F> for ErrorOOGMemoryCopyGadget<F> {
         };
 
         let dst_offset = rws.next().stack_value();
-
         let src_offset = rws.next().stack_value();
-
         let copy_size = rws.next().stack_value();
 
         self.opcode

diff --git a/zkevm-circuits/src/evm_circuit/execution/extcodehash.rs b/zkevm-circuits/src/evm_circuit/execution/extcodehash.rs
@@ -110,7 +110,6 @@ impl<F: Field> ExecutionGadget<F> for ExtcodehashGadget<F> {
         let mut rws = StepRws::new(block, step);
 
         let address = rws.next().stack_value();
-
         self.address_word.assign_u256(region, offset, address)?;
 
         self.tx_id

diff --git a/zkevm-circuits/src/evm_circuit/execution/sload.rs b/zkevm-circuits/src/evm_circuit/execution/sload.rs
@@ -126,9 +126,7 @@ impl<F: Field> ExecutionGadget<F> for SloadGadget<F> {
         rws.offset_add(4);
 
         let key = rws.next().stack_value();
-
         let (_, committed_value) = rws.next().aux_pair();
-
         let value = rws.next().stack_value();
 
         self.key.assign_u256(region, offset, key)?;