circuit for maxcodesize exceed & code store oog

[DreamWuGit]

Description

circuit for maxcodesize exceed & code store oog
markdown spec is privacy-scaling-explorations/zkevm-specs#393

Issue Link

#1259

Type of change

• New feature (non-breaking change which adds functionality)

This PR contains:

• merge oog codestore and maxcodesize exceed error into one
• buss mapping & circuit
• tests for both two error cases(create / create2)
• fix get_step_err fix get_step_error for tx deploy case #1275
• test for tx deploy (tx.to = null )

Design choices

• make error check on RETURN op code not create itself.

[lispc]

there are 3 ways to deploy contracts CREATE opcode / CREATE2 opcode / tx.to = None .

seems only the first 2 are tested here?

[DreamWuGit]

there are 3 ways to deploy contracts CREATE opcode / CREATE2 opcode / tx.to = None .

seems only the first 2 are tested here?

make sense , even tx.to = None use same create method in core/vm/evm.go, better to have single test for it.

[CPerezz]

We will need to add the not STATICCALL constraint in here as pointed in the specs PR.

I'll wait until we merge the specs to do the complete review. As this still needs to be updated.

[aguzmant103]

@DreamWuGit just following up, have you had a chance to update this PR?

[DreamWuGit]

@DreamWuGit just following up, have you had a chance to update this PR?

will update & rebase soon!

[DreamWuGit]

@aguzmant103 I notice this is create gadget related error, now create gadget PR still pending (not merged) , so a few test failed.

[ed255]

Current status of this PR is that it depends on create gadget:

• [CREATE Part A] Modification to Copy Circuit #1356
• [CREATE Part B] Error cases that will be handled within opcode gadgets #1357
• [CREATE Part C] bus-mapping and gadget implementation #1358

[ChihChengLiang]

This task is unblocked

[silathdiir]

This task is unblocked

Will update this PR.

[KimiWu123]

@silathdiir , is this PR ready for review?

[silathdiir]

@silathdiir , is this PR ready for review?

Sorry, no. I haven't started to work on it. Will start to fix it in next week.

[DreamWuGit]

this PR is much outdated, make new one here #1545, closing this one now.