This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Feat/CREATE Part B - Error cases that will be handled within opcode gadgets #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
4 tasks
4 tasks
KimiWu123
changed the title
KimiWu123
changed the title
KimiWu123
force-pushed
the
feat/create-part-b
branch
2 times, most recently
from
88db436
to
eb9514d
Compare
github-actions
bot
removed
the
crate-mock
KimiWu123
force-pushed
the
feat/create-part-b
branch
from
eb9514d
to
0b66d2a
Compare
lispc
reviewed
May 25, 2023
| @@ -1295,9 +1292,6 @@ impl<F: Field> ExecutionConfig<F> { | |||
| ExecutionState::ErrorDepth => { | |||
| assign_exec_step!(self.error_depth) | |||
| } | |||
| ExecutionState::ErrorContractAddressCollision => { | |||
| assign_exec_step!(self.error_contract_address_collision) | |||
| } | |||
There was a problem hiding this comment.
since ErrDepth will be processed inside create gadget and call gadget, we can remove this code too?
ExecutionState::ErrorDepth => {
assign_exec_step!(self.error_depth)
}
lispc
approved these changes
May 25, 2023
|
Hi @lispc and @han0110 , in order to remove |
KimiWu123
added a commit
that referenced
this pull request
Jun 9, 2023
### Description NOTE: This is an updated version of #1358 This PR is actually based on top of #1425 ### Issue Link #1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents Bus mapping implementation for CREATE/CREATE2 EVM circuit's gadget for CREATE/CREATE2 ### How Has This Been Tested? Tests can be found here: https://github.com/scroll-tech/zkevm-circuits/blob/2d2bfc6ccf179ade1a8d063f9586b93e5283a557/zkevm-circuits/src/evm_circuit/execution/create.rs#L678 --------- Co-authored-by: Rohit Narurkar <[email protected]>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is an updated version of #1357
This PR is actually based on top of #1419
Issue Link
#1130
Type of change
Contents
Error types for insufficient balance and nonce overflow. These are supporting changes required for the CREATE/CREATE2 opcodes' gadget.
Rationale
The above errors will be handled within the CREATE/CREATE2 opcodes' gadget. In case of insufficient balance, it is also handled in the CallOp gadget for call related opcodes.