-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LinkedIn Issuer #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
w-ensink
commented
Nov 29, 2024
•
edited
Loading
edited
- Make LinkedIn work with their new OpenID Connect API
- Upgrade irma-frontend to yivi-frontend
- Fix logout text (was using undefined attribute)
- Upgrade simplesamlphp version to 2.3.4 (which patches security hole)
- Add workflow that uploads a docker container to GHCR on every PR with the name of the feature branch
- Update Issuer ID to pbdf-staging.pbdf
- fullname is not defined for linkedin
w-ensink
changed the title
push to ghcr on PR using branch name as tag
Fix LinkedIn Issuer
Dec 2, 2024
DibranMulder
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly twitter doesn't work yet, but we are not debugging SimpleSamlPHP for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.