Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update!: Remove Fluent Reader #2801

Merged
merged 1 commit into from
Nov 10, 2024
Merged

update!: Remove Fluent Reader #2801

merged 1 commit into from
Nov 10, 2024
+18 −41

Conversation

redoomed1
Copy link
Member

List of changes proposed in this PR:

  • Remove Fluent Reader, which, due to it being unmaintained for over a year, is severely lagging behind in Electron updates
  • Add threat model label to the News Aggregator page (I somehow missed this in the previous PRs)
  • NewsFlash
    • In the card description, remove the sentence about the app only being available as a Flatpak on Flathub since the Downloads section already makes that clear
    • Simplify the card description further
  • Style Changes
    • Standardize syntax for tooltips
    • Add Oxford commas where appropriate, which are considered mandatory by APA Style guidelines
    • Shorten links where appropriate
    • Make other minor grammar changes not noted above

@redoomed1 redoomed1 changed the title update!: Remove fluent reader update!: Remove Fluent Reader Nov 4, 2024
@redoomed1 redoomed1 added the c:software self-hosted/decentralized software and related topics label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit d98db5b
😎 Preview https://2801--glowing-salamander-8d7127.netlify.app/

@redoomed1 redoomed1 force-pushed the remove-fluent-reader branch from 78cc091 to 037103a Compare November 4, 2024 17:24
dngray
dngray approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redoomed1 @dngray
update!: Remove Fluent Reader (#2801)
d98db5b 
Signed-off-by: fria <[email protected]>
Signed-off-by: Daniel Gray <[email protected]>
@dngray dngray force-pushed the remove-fluent-reader branch from 037103a to d98db5b Compare November 10, 2024 07:24
@dngray dngray merged commit d98db5b into main Nov 10, 2024
14 of 16 checks passed
@dngray dngray deleted the remove-fluent-reader branch November 10, 2024 07:25
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-11-11/22347/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friadev friadev friadev approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:software self-hosted/decentralized software and related topics
Projects
PR Review Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redoomed1 @privacyguides-bot @dngray @friadev