-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Tidy up Cryptocurrency page and recommend places to buy Monero #2823
Conversation
This pull request has been mentioned on Privacy Guides Community. There might be relevant details there: https://discuss.privacyguides.net/t/suggestion-elaborate-how-to-get-monero/16817/15 |
✅ Your preview is ready!
Please note that this preview was built from an untrusted source, so it was not granted access to all mkdocs-material features. Maintainers should ensure this PR has been reviewed locally with a full build before merging. |
Seems like the geographical restrictions admonition box and the footnotes are not formatted correctly. How do I fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestions! I kindly request that we wait until MAGIC Grants can do a legal review of proposed money/cryptocurrency PRs before merging, due to the sensitivity of some related laws. This is something we should get to this weekend or early next week. Thank you for your understanding!
Thank you that's absolutely no problem. By the way, Kraken and Cake Wallet are mentioned on the website currently (in advanced/payments.md and cryptocurrency.md respectively). Only Reto is new but seems to be the "go-to" recommendation in the Monero community since LocalMonero shut down. |
@eylenburg please check to see if you have any questions or concerns with the changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The internal links for the Notices and Disclaimers page on each edited page are broken, which need to be fixed before merging.
New website for Retoswap is online now: https://retoswap.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only minor suggestion I have for you is to replace the old RetoSwap URL with the new one you posted earlier.
Otherwise, this PR looks good to me. Thanks y'all!
privacyguides#2823) Signed-off-by: redoomed1 <[email protected]> Signed-off-by: Daniel Gray <[email protected]>
Suggested changes have been applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggested changes attempt to streamline the info about geographical restrictions and avoid unnecessary maintenance burden as hinted by Jonah here.
privacyguides#2823) Signed-off-by: redoomed1 <[email protected]> Signed-off-by: Daniel Gray <[email protected]>
List of changes proposed in this PR:
The main change is adding some recommendations for where to buy Monero. This a list of various reputable places with different requirements (Kraken: KYC ok; Cake Wallet: avoid KYC; RetoSwap: P2P and no country restrictions).
I also added some sub-headings for wallets and nodes and put the comments about Monero's resilience in a summary+detail box.
Finally, some cross-linking between the advanced/payments.md and the cryptocurrency.md pages.
I have just written this in Markdown so hopefully the end result will render correctly. Also happy for to make changes, this is just a first draft.