Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Tidy up Cryptocurrency page and recommend places to buy Monero #2823

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

eylenburg
Copy link
Contributor

List of changes proposed in this PR:

The main change is adding some recommendations for where to buy Monero. This a list of various reputable places with different requirements (Kraken: KYC ok; Cake Wallet: avoid KYC; RetoSwap: P2P and no country restrictions).

I also added some sub-headings for wallets and nodes and put the comments about Monero's resilience in a summary+detail box.

Finally, some cross-linking between the advanced/payments.md and the cryptocurrency.md pages.

I have just written this in Markdown so hopefully the end result will render correctly. Also happy for to make changes, this is just a first draft.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/suggestion-elaborate-how-to-get-monero/16817/15

Copy link

github-actions bot commented Nov 27, 2024

Your preview is ready!

Name Link
🔨 Latest commit 9851037
😎 Preview https://pr2823.unreviewed.privacyguides.dev/en/

Please note that this preview was built from an untrusted source, so it was not granted access to all mkdocs-material features. Maintainers should ensure this PR has been reviewed locally with a full build before merging.

@eylenburg
Copy link
Contributor Author

Seems like the geographical restrictions admonition box and the footnotes are not formatted correctly. How do I fix it?

@friadev friadev marked this pull request as draft November 28, 2024 03:21
@eylenburg eylenburg marked this pull request as ready for review November 28, 2024 10:55
Copy link
Contributor

@SamsungGalaxyPlayer SamsungGalaxyPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions! I kindly request that we wait until MAGIC Grants can do a legal review of proposed money/cryptocurrency PRs before merging, due to the sensitivity of some related laws. This is something we should get to this weekend or early next week. Thank you for your understanding!

@eylenburg
Copy link
Contributor Author

Thank you that's absolutely no problem.

By the way, Kraken and Cake Wallet are mentioned on the website currently (in advanced/payments.md and cryptocurrency.md respectively). Only Reto is new but seems to be the "go-to" recommendation in the Monero community since LocalMonero shut down.

@friadev friadev changed the title Draft: tidying up the Monero section and recommending some places to buy it from update: tidying up the Monero section and recommending some places to buy it from Nov 29, 2024
@SamsungGalaxyPlayer
Copy link
Contributor

@eylenburg please check to see if you have any questions or concerns with the changes. Thanks!

Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal links for the Notices and Disclaimers page on each edited page are broken, which need to be fixed before merging.

docs/cryptocurrency.md Outdated Show resolved Hide resolved
docs/cryptocurrency.md Outdated Show resolved Hide resolved
docs/cryptocurrency.md Outdated Show resolved Hide resolved
docs/cryptocurrency.md Outdated Show resolved Hide resolved
docs/financial-services.md Outdated Show resolved Hide resolved
docs/advanced/payments.md Outdated Show resolved Hide resolved
@eylenburg
Copy link
Contributor Author

New website for Retoswap is online now: https://retoswap.com/

@redoomed1 redoomed1 added the c:software self-hosted/decentralized software and related topics label Dec 1, 2024
@redoomed1 redoomed1 changed the title update: tidying up the Monero section and recommending some places to buy it from update: Tidy up Monero recommendation page and recommend places to buy Monero Dec 1, 2024
@redoomed1 redoomed1 changed the title update: Tidy up Monero recommendation page and recommend places to buy Monero update: Tidy up Monero recommendation and recommend places to buy Monero Dec 1, 2024
@redoomed1 redoomed1 changed the title update: Tidy up Monero recommendation and recommend places to buy Monero update: Tidy up Cryptocurrency page and recommend places to buy Monero Dec 1, 2024
redoomed1

This comment was marked as outdated.

@redoomed1 redoomed1 dismissed their stale review December 1, 2024 15:30

missing suggestion

Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only minor suggestion I have for you is to replace the old RetoSwap URL with the new one you posted earlier.

Otherwise, this PR looks good to me. Thanks y'all!

docs/cryptocurrency.md Outdated Show resolved Hide resolved
dngray pushed a commit to eylenburg/privacyguides.org that referenced this pull request Dec 10, 2024
@jonaharagon jonaharagon dismissed SamsungGalaxyPlayer’s stale review December 13, 2024 03:02

Suggested changes have been applied

docs/cryptocurrency.md Outdated Show resolved Hide resolved
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggested changes attempt to streamline the info about geographical restrictions and avoid unnecessary maintenance burden as hinted by Jonah here.

docs/cryptocurrency.md Show resolved Hide resolved
docs/cryptocurrency.md Outdated Show resolved Hide resolved
docs/cryptocurrency.md Outdated Show resolved Hide resolved
redoomed1 pushed a commit to eylenburg/privacyguides.org that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants