Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the fact that Closure advanced optimizations are disabled #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document the fact that Closure advanced optimizations are disabled #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This project benchmarks the following minifiers:
- [babel-minify](https://github.com/babel/minify/tree/master/packages/babel-minify) <sub>v0.5.2</sub>
- [bun](https://github.com/oven-sh/bun) <sub>v1.1.29</sub>
- [esbuild](https://github.com/evanw/esbuild) <sub>v0.24.0</sub>
- [google-closure-compiler](https://github.com/google/closure-compiler-npm/tree/master/packages/google-closure-compiler) <sub>v20240317.0.0</sub>
- [google-closure-compiler](https://github.com/google/closure-compiler-npm/tree/master/packages/google-closure-compiler) <sub>v20240317.0.0, advanced optimizations disabled</sub>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is generated (between <!-- minifiers:start --> and <!-- minifiers:end -->) so this will get overwritten.

- [tedivm/jshrink](https://github.com/tedious/JShrink) <sub>v1.7.0</sub>
- [@swc/core](https://github.com/swc-project/swc) <sub>v1.7.28</sub>
- [@tdewolff/minify](https://github.com/tdewolff/minify#readme) <sub>v2.20.37</sub>
Expand Down Expand Up @@ -43,6 +43,10 @@ _Benchmarks last updated on <!-- lastUpdated:start -->Sep 26, 2024<!-- lastUpdat
- Minifier upgrade PRs are automated via [WhiteSource Renovate](https://www.whitesourcesoftware.com/free-developer-tools/renovate/)
- Benchmarks are updated on every PR via [GitHub Actions](https://github.com/privatenumber/minification-benchmarks/actions/workflows/benchmark.yml)

## Caveats

- Google Closure Compiler has an ["advanced optimizations" feature](https://developers.google.com/closure/compiler/docs/api-tutorial3), but using those optimizations requires structuring code in a certain way. Our benchmarks focus on popular libraries with the assumption that we cannot alter the code we're minifying. Thus, our Closure Compiler tests don't use advanced optimizations.

## ⏱ Metrics

Minifiers are ranked by smallest minzipped size.
Expand Down