Fix sqlalchemy dependency #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hemy as problematic. Conda says, when building the notebook image, that bayeslite has an indirect dependency to sqlalchemy. However, when I make this dependency explicit, bayeslite complains that CGPM doesn't like. Thus pushing to a branch here to see the conda build on travis. Sosqlalchemy making this dependency explicit and bumping it's version should solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a requirement by our industrial collaborator to bump the version of sqlalchemy.
sqlalchemy is a dependency of CGPM. I tracked this down to CGPM through our build system (when I set the sqlalchemy version in our image itself -- Conda's sat solver found incompatibility with Bayeslite. When I set the version in Bayeslite Conda's sat solver found incompatibility CGPM. CGPM seems to be happy with an upgraded version.