Sometimes::incorporate must pass weight when calling incorporate on i…

…ts members!
probcomp · Jul 10, 2024 · 26bbc4d · 26bbc4d
1 parent cef8528
commit 26bbc4d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/cxx/emissions/sometimes.hh b/cxx/emissions/sometimes.hh
@@ -29,18 +29,18 @@ class Sometimes : public Emission<SampleType> {
                    double weight = 1.0) {
     this->N += weight;
     if (x.first != x.second) {
-      bb.incorporate(true);
-      be->incorporate(x);
+      bb.incorporate(true, weight);
+      be->incorporate(x, weight);
       return;
     }
     if (can_dirty_equal_clean) {
       double p_came_from_be = exp(bb.logp(true) + be->logp(x));
-      bb.incorporate(true, p_came_from_be);
-      be->incorporate(x, p_came_from_be);
-      bb.incorporate(false, 1.0 - p_came_from_be);
+      bb.incorporate(true, p_came_from_be * weight);
+      be->incorporate(x, p_came_from_be * weight);
+      bb.incorporate(false, (1.0 - p_came_from_be) * weight);
       return;
     }
-    bb.incorporate(false);
+    bb.incorporate(false, weight);
   }
 
   double logp(const std::pair<SampleType, SampleType>& x) const {