Fix categorical logp to be conditional probability

probcomp · Jul 8, 2024 · d4d6012 · d4d6012
1 parent ac14bd5
commit d4d6012
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/cxx/emissions/categorical.hh b/cxx/emissions/categorical.hh
@@ -31,15 +31,7 @@ class CategoricalEmission : public Emission<int> {
   }
 
   double logp(const std::pair<int, int>& x) const {
-    double lp;
-    for (size_t i = 0; i < emission_dists.size(); ++i) {
-      if (std::cmp_equal(i, x.first)) {
-        lp += emission_dists[i].logp(x.second);
-      } else {
-        lp += emission_dists[i].logp_score();
-      }
-    }
-    return lp;
+    return emission_dists[x.first].logp(x.second);
   }
 
   double logp_score() const {

diff --git a/cxx/emissions/categorical_test.cc b/cxx/emissions/categorical_test.cc
@@ -22,7 +22,7 @@ BOOST_AUTO_TEST_CASE(test_simple) {
   ce.incorporate(std::make_pair<int, int>(4, 4));
   BOOST_TEST(ce.N == 2);
 
-  BOOST_TEST(ce.logp(std::make_pair<int, int>(2, 2)) == -4.8283137373023006,
+  BOOST_TEST(ce.logp(std::make_pair<int, int>(2, 2)) == -1.6094379124341003,
              tt::tolerance(1e-6));
 
   std::mt19937 prng;