Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrame class than can be read from a csv file #111

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@srvasude srvasude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this is in the pclean directory (I don't think I know the purpose of the pclean directory / should it be renamed?)

@ThomasColthurst
Copy link
Collaborator Author

Is there a reason that this is in the pclean directory (I don't think I know the purpose of the pclean directory / should it be renamed?)

The pclean directory is to hold the code (libraries and binary) that takes a PClean-style schema as input. Right now, that's the only intended user of this CSV code, so that's why I put it there. It assumes that every line has the same number of values, which I think makes it unsuitable for handling HIRM observations (where the relations can different arities)

@ThomasColthurst ThomasColthurst merged commit b8236df into master Jul 30, 2024
1 check passed
@ThomasColthurst ThomasColthurst deleted the 072924-thomaswc-csv branch July 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants