Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fast string alignments even with bad edit distances #144

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

Fixes #142

Copy link
Collaborator

@emilyfertig emilyfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

// Does this alignment reach the end of both strings? If so, ship it.
double old_cost = -heap_top.cost;
printf("pos1 %ld pos2 %ld cost %f\n", heap_top.s1_position,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, if this was for debugging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done.

@ThomasColthurst ThomasColthurst merged commit 50ce879 into master Aug 7, 2024
2 checks passed
@ThomasColthurst ThomasColthurst deleted the 080724-thomaswc-fixalign branch August 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporating PClean flights data causes hang in string_alignment::topk_alignments
2 participants