Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in -c opt mode by not doing work inside asserts #164

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix tests in -c opt mode by not doing work inside asserts #164

merged 1 commit into from
Aug 13, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

Fixes #153

emilyfertig
emilyfertig approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@emilyfertig emilyfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ThomasColthurst ThomasColthurst merged commit d389339 into master Aug 13, 2024
2 checks passed
@ThomasColthurst ThomasColthurst deleted the 081224-thomaswc-copt branch August 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyfertig emilyfertig emilyfertig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util_io_test.cc is failing at head
2 participants
@ThomasColthurst @emilyfertig