Add StringNat distribution and typo_nat joint distribution #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srvasude
approved these changes
Aug 15, 2024
|
|
||
| Bigram(size_t _max_length = 80): max_length(_max_length) { | ||
| Bigram(size_t _max_length = 80, | ||
| char _min_char = ' ', |
There was a problem hiding this comment.
Is there a reason these need to be constructor arguments / modifiable? Should/can we keep these as macro constants / static const members?
There was a problem hiding this comment.
Yeah, so the reason I changed them to be constructor arguments is that they are used in constructor (to calculate num_chars, which in turn is used to make the transition_dist tables).
I wanted the subclass to change them, but also be able to call the parent's constructor to do the necessary work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167